Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(NcSelect): Improve accessibility #5036

Merged
merged 4 commits into from Jan 9, 2024
Merged

enh(NcSelect): Improve accessibility #5036

merged 4 commits into from Jan 9, 2024

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Jan 9, 2024

Summary

  • Bump vue-select to v3.25.0 with a11y fixes
  • Add ariaLabelListbox
  • Minor fixes

馃弫 Checklist

  • 鉀戯笍 Tests are included or are not applicable
  • 馃摌 Component documentation has been extended, updated or is not applicable

@Pytal
chore(deps): Bump @nextcloud/vue-select to v3.25.0
65bb72a 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix(NcSelect): Cursor style
e9cebd9 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore(NcSelect): Remove double hyphen in id
c107ff2 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
enh(NcSelect): Add ariaLabelListbox prop
0b57e19 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added enhancement New feature or request 3. to review Waiting for reviews feature: select Related to the NcSelect* components accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Jan 9, 2024
@Pytal Pytal added this to the 8.5.0 milestone Jan 9, 2024
@Pytal Pytal self-assigned this Jan 9, 2024
@susnux susnux merged commit fd53abe into master Jan 9, 2024
16 checks passed
@susnux susnux deleted the deps/nextcloud/vue-select-3.25.0 branch January 9, 2024 10:27
@Pytal Pytal mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@emoral435 emoral435 Awaiting requested review from emoral435

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities enhancement New feature or request feature: select Related to the NcSelect* components
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pytal @susnux @ShGKme