Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcDateTimePicker): Use ISO week numbers if showWeekNumber is set #5045

Merged
merged 1 commit into from Jan 10, 2024
Merged

fix(NcDateTimePicker): Use ISO week numbers if showWeekNumber is set #5045

merged 1 commit into from Jan 10, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 9, 2024

☑️ Resolves

Use ISO week numbers by default, but still allow users to override it using the formatter prop.

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot_20240109_135501 Screenshot_20240109_135514

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: datepicker Related to the date/time picker component labels Jan 9, 2024
@susnux susnux force-pushed the fix/date-time-picker-isoweeks branch from eae1d3a to c1c2f68 Compare January 9, 2024 20:15
@susnux susnux modified the milestones: 8.5.0, 8.4.1 Jan 9, 2024
raimund-schluessler
raimund-schluessler approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍
There are just two trailing commas missing.

@susnux
fix(NcDateTimePicker): Use ISO week numbers if showWeekNumber is set
3d0acc8 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/date-time-picker-isoweeks branch from c1c2f68 to 3d0acc8 Compare January 9, 2024 23:50
@susnux
Copy link
Contributor Author

susnux commented Jan 9, 2024

There are just two trailing commas missing.

fixed

@susnux susnux requested a review from Pytal January 9, 2024 23:50
@raimund-schluessler raimund-schluessler merged commit 0b1a3be into master Jan 10, 2024
15 checks passed
@raimund-schluessler raimund-schluessler deleted the fix/date-time-picker-isoweeks branch January 10, 2024 20:53
@raimund-schluessler raimund-schluessler mentioned this pull request Jan 10, 2024
Closed
@susnux susnux modified the milestones: 8.4.1, 8.5.0 Jan 15, 2024
@Pytal Pytal mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@ShGKme ShGKme ShGKme approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working feature: datepicker Related to the date/time picker component
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.

NcDateTimePicker week labels off by one
3 participants
@susnux @raimund-schluessler @ShGKme