Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(NcHeaderMenu): Close navigation header menu on focusout #5064

Merged
merged 1 commit into from Jan 14, 2024
Merged

enh(NcHeaderMenu): Close navigation header menu on focusout #5064

merged 1 commit into from Jan 14, 2024

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Jan 13, 2024

Summary

  • Close the menu automatically on focusout
  • Alternative way using keydown is not sufficient as users may switch focus to an external element by targetting it directly via e.g. mouse or screen reader

馃弫 Checklist

  • 鉀戯笍 Tests are included or are not applicable
  • 馃摌 Component documentation has been extended, updated or is not applicable

@Pytal
enh(NcHeaderMenu): Close navigation header menu on focusout
4e24c99 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added enhancement New feature or request 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Jan 13, 2024
@Pytal Pytal added this to the 8.5.0 milestone Jan 13, 2024
@Pytal Pytal self-assigned this Jan 13, 2024
ShGKme
ShGKme approved these changes Jan 13, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Probably we should even do the same with all popovers without focus trap.

@ShGKme
Copy link
Contributor

ShGKme commented Jan 13, 2024

Cool solution!

@susnux susnux merged commit 0b9f464 into master Jan 14, 2024
15 checks passed
@susnux susnux deleted the enh/a11y/header-menu-focusout branch January 14, 2024 12:27
@Pytal Pytal mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@artonge artonge Awaiting requested review from artonge

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities enhancement New feature or request
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pytal @ShGKme @susnux