Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcRelatedResourcesPanel): Fix invalid URL query params #5065

Merged
merged 1 commit into from Jan 15, 2024

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Jan 13, 2024

☑️ Resolves

Set the correct default query params https://github.com/nextcloud/related_resources/blob/dd5cc9bcb88d309bcf992de856d3095f7fa7d42b/lib/Controller/ApiController.php#L94-L95

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added bug Something isn't working 3. to review Waiting for reviews feature: related resources panel Related to the NcRelatedResourcesPanel component labels Jan 13, 2024
@Pytal Pytal added this to the 8.4.1 milestone Jan 13, 2024
@Pytal Pytal self-assigned this Jan 13, 2024
@GretaD GretaD merged commit 31827fd into master Jan 15, 2024
15 checks passed
@GretaD GretaD deleted the fix/related-resources-url branch January 15, 2024 09:41
@susnux susnux modified the milestones: 8.4.1, 8.5.0 Jan 15, 2024
@Pytal Pytal mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: related resources panel Related to the NcRelatedResourcesPanel component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Related resource are broken
5 participants