Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NcProgressBar): add circular progress bar #5100

Merged
merged 1 commit into from Jan 22, 2024
Merged

feat(NcProgressBar): add circular progress bar #5100

merged 1 commit into from Jan 22, 2024

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Jan 20, 2024 •
edited

☑️ Resolves

🖼️ Screenshots

No visual changes to existing components, no breaking changes.

grafik

Used in the Tasks app it looks like this:
grafik

@raimund-schluessler raimund-schluessler added this to the 8.5.0 milestone Jan 20, 2024
@raimund-schluessler raimund-schluessler added enhancement New feature or request 3. to review Waiting for reviews labels Jan 20, 2024
@raimund-schluessler raimund-schluessler mentioned this pull request Jan 20, 2024
Merged
@raimund-schluessler raimund-schluessler marked this pull request as ready for review January 20, 2024 12:51
szaimen
szaimen approved these changes Jan 21, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from design perspective. Thanks for implementing this! :)

ShGKme
ShGKme approved these changes Jan 21, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Just some docs/a11y comments

@raimund-schluessler
Copy link
Contributor Author

Should be adjusted now.

@raimund-schluessler
feat(NcProgressBar): add circular progress bar
6425e8c 
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler merged commit d6b87ef into master Jan 22, 2024
15 checks passed
@raimund-schluessler raimund-schluessler deleted the feat/noid/circular-progress branch January 22, 2024 10:00
@Pytal Pytal mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

@szaimen szaimen szaimen approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@Pytal Pytal Awaiting requested review from Pytal

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@raimund-schluessler @susnux @ShGKme @szaimen