fix(NcActions): use new slots api #5118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
added
bug
ShGKme
force-pushed
the
fix/nc-actions--support-new-slots-api
branch
from
089be7c
to
49d4233
Compare
- Since Vue 2.6 with new slots api, it is guaranteed that $scopedSlots has render function for all slots passed any way, while $slots only has value when using deprecated API or short-hand syntax - It also closer to Vue 3 API - `before` method is removed, there is no such lifecycle hook Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/nc-actions--support-new-slots-api
branch
from
49d4233
to
b94ff04
Compare
susnux
approved these changes
Jan 23, 2024
skjnldsv
approved these changes
Jan 23, 2024
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
$scopedSlotshas render function for all slots passed any way, while$slotsonly has value when using deprecated API or short-hand syntaxbeforemethod is removed, there is no such lifecycle hookIt allows dynamically defining text content of the component in template without the need to rewrite the component to render-function.
See: https://v2.vuejs.org/v2/api/#vm-scopedSlots
🖼️ Screenshots
When using non-deprecated slots api:
🏁 Checklist