Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcButton): pressed state a11y #5119

Merged
merged 1 commit into from Jan 23, 2024
Merged

fix(NcButton): pressed state a11y #5119

merged 1 commit into from Jan 23, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jan 23, 2024

☑️ Resolves

  • area-pressed should be false when not pressed
  • pressed should only be present on buttons, not links
  • fix example to not change text on press

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@ShGKme
fix(NcButton): pressed state a11y
4a12c13 
- area-pressed should be false when not pressed
- pressed should only be present on buttons, not links
- fix example to not change text on press

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: button labels Jan 23, 2024
@ShGKme ShGKme added this to the 8.5.0 milestone Jan 23, 2024
@ShGKme ShGKme self-assigned this Jan 23, 2024
@ShGKme ShGKme mentioned this pull request Jan 23, 2024
Merged
2 tasks
@susnux susnux mentioned this pull request Jan 23, 2024
Merged
@ShGKme ShGKme merged commit 1498ede into master Jan 23, 2024
15 checks passed
@ShGKme ShGKme deleted the fix/nc-button--pressed-a11y branch January 23, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: button
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ShGKme @susnux @JuliaKirschenheuter