chore(styleguide): set line-height from server styles #5132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
requested review from
ChristophWurst,
susnux,
raimund-schluessler and
Pytal
2 tasks
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
chore/styleguide-line-height
branch
4 times, most recently
from
6339742
to
6d6deda
Compare
ChristophWurst
approved these changes
Jan 25, 2024
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
susnux
approved these changes
Jan 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Because of re-assigned
line-heightin docs, some components look a little bit different from the server. It may result in incorrect debug and components implementation.For example, the position of the
labelinNc*Fieldis correct on Styleguidist but actually it is not.🖼️ Screenshots
🏁 Checklist