fix(NcPopover): a11y attrs provide-inject reactivity #5142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
added
bug
ShGKme
requested review from
susnux,
raimund-schluessler,
juliushaertl,
JuliaKirschenheuter and
Pytal
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/nc-popover--provide-reactivity
branch
from
797084b
to
7e1368c
Compare
|
Maybe the issue is because Viewer is using not the latest Vue patch |
Pytal
approved these changes
Jan 26, 2024
susnux
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
works but not that nice @raimund-schluessler probably do not port to vue3(?)
Getter function will work in Vue 3 too. Or what do you mean? |
It also works without in Vue3 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Though it must be fine in Vue 3.3+, for some reason, sometimes
computedinprovide/injectis not reactive.It works in
docs, inserver, inTalk. But it doesn't work inText...We had a similar issue with provide/inject in
NcSidebarTabsin past.@raimund-schluessler I also included a small fix with
internalShownbased on your comment somewhere🏁 Checklist