Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcActions): keyboard navigation #5153

Merged
merged 5 commits into from Jan 26, 2024
Merged

fix(NcActions): keyboard navigation #5153

merged 5 commits into from Jan 26, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jan 26, 2024 •
edited

☑️ Resolves

Fixes keyboard navigation in two cases:

  1. When a menu type is determined incorrect because inline actions were taken into account
    • E.g. where is an inline button and we thought, it is in the menu
  2. Correctly handle Tab blur, when there is no focusable element in the actions

There are quite a lot of changes.

Separated with 💙 into small commits to be easier to review.

🖼️ Screenshots

🏚️ Before 🏡 After
before-tab after-tab

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@ShGKme
refactor(NcActions): reuse getActionName method
f502143 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
refactor(NcActions): better name inline and menu action items vars
b66bfc8 
- `inlineActions` -> `validInlineActions` like it is said in filter, because not all of them are to be inline
- `renderedInlineActions` -> `inlineActions` because they are not rendered yet and to be consistent with `menuActions`

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Jan 26, 2024
@ShGKme ShGKme added this to the 8.5.1 milestone Jan 26, 2024
@ShGKme ShGKme self-assigned this Jan 26, 2024
@ShGKme
refactor(NcActions): move separating inline/menu items code in one place
dbee003 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
fix(NcActions): don't include inline actions in menu semantics
bb05b7b 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
fix(NcActions): handle text-only popup keyboard navigation
f26764a 
- Add new semantic type - tooltip (popup with text only, without interactive elements)
- Simplify semantic types logic
- Manually close tooltips on blur

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the fix/nc-actions--keyboard-navigation branch from c1f2478 to f26764a Compare January 26, 2024 21:03
@ShGKme ShGKme mentioned this pull request Jan 26, 2024
Merged
2 tasks
Pytal
Pytal approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean commits!

@susnux susnux modified the milestones: 8.5.1, 8.6.0 Jan 26, 2024
@susnux susnux merged commit c9cc3e7 into master Jan 26, 2024
15 checks passed
@susnux susnux deleted the fix/nc-actions--keyboard-navigation branch January 26, 2024 23:45
@ShGKme ShGKme mentioned this pull request Jan 30, 2024
Merged
4 tasks
@Antreesy Antreesy mentioned this pull request Jan 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Pytal Pytal Pytal approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: actions Related to the actions components
Projects
None yet
Milestone
8.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ShGKme @susnux @Pytal