Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcSelect): list width on page scaling #5162

Merged
merged 1 commit into from Jan 29, 2024
Merged

fix(NcSelect): list width on page scaling #5162

merged 1 commit into from Jan 29, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jan 28, 2024

By default Vue-Select takes width for content list on element insert.
But if select is resized after opening (for example, on page scale), that width is not actual anymore.
Manually set width according to the toggle element on update.

The current solution is a bit glitchy when select has flexible width. Not sure, how to fix better.

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
select-before select-after
select-before-2 select-after-2

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@ShGKme
fix(NcSelect): list width on page scaling
9c8a3ff 
By default Vue-Select takes width for content list on element insert.
But if select is resized after opening (for example, on page scale), that width is not actual anymore.
Manually set width according to the toggle element on update.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: select Related to the NcSelect* components accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Jan 28, 2024
@ShGKme ShGKme added this to the 8.6.1 milestone Jan 28, 2024
@ShGKme ShGKme self-assigned this Jan 28, 2024
raimund-schluessler
raimund-schluessler approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal, but works a lot better than before already 👍

@susnux susnux merged commit 25d0813 into master Jan 29, 2024
15 checks passed
@susnux susnux deleted the fix/nc-select--width-on-scaling branch January 29, 2024 12:31
@susnux susnux modified the milestones: 8.5.2, 8.6.0 Jan 29, 2024
@Antreesy Antreesy mentioned this pull request Jan 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@artonge artonge Awaiting requested review from artonge

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: select Related to the NcSelect* components
Projects
None yet
Milestone
8.6.0
Development

Successfully merging this pull request may close these issues.

[NcSelect] Minor presentation issue
3 participants
@ShGKme @susnux @raimund-schluessler