-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[next] chore(master): merge master
into next
#5184
Conversation
E.g. the file reference widget should work with links to Nextcloud on localhost. Also add some basic unit tests to prevent regressions with the regexes in the future. Signed-off-by: Jonas <jonas@freesources.org>
…attern fix(NcRichText): Make URL_PATTERN match localhost and URLs with ports
Signed-off-by: Grigorii K. Shartsev <me@shgk.me> Co-authored-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me> Co-authored-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
…tom-children fix(NcActions): hotfix for custom children
… on system default theme Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…ssibility_to_change_a_color_theme_for_native_datetime_picker-on-default-theme Create possibility to change a color theme for native datetime picker on system default theme
chore: Update workflows
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
chore: prepare 8.6.0 release
The issue is not related to this PR. Such usage of So this PR only adds an example of this limitation to the docs. We need to find a more generic solution to solve #5171 |
@@ -1091,7 +1218,7 @@ export default { | |||
* @return {boolean} | |||
*/ | |||
isValidSingleAction(action) { | |||
return ['NcActionButton', 'NcActionLink', 'NcActionRouter'].includes(this.getActionName(action)) | |||
return ['NcActionButton', 'NcActionLink', 'NcActionRouter'].some(valid => this.getActionName(action).startsWith(valid)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change to startsWith
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we could introduce a naming convention for these wrappers. So if the components name starts with NcActions, we just pass it on. But that wasn't fully thought through and didn't work yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an alternative, we could ask to add a custom option and check $options
.
But this won't help in a general case. Developers may make wrappers for a list of actions
<template>
<div>
<NcActionButton />
<NcActionInput />
</div>
</template>
Or dynamic actions. Like, I dunno,
<template>
<NcActionButton v-if="iLikeButtons" />
<NcActionInput v-else-if="iDont" />
</template>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or dynamic actions. Like, I dunno
Have this in forms: https://github.com/nextcloud/forms/blob/e1cfbc737234e0bd3ff10f8a1222223a8093e254/src/views/Results.vue#L134
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have this in forms:
This will work. I meant when those <template>...</template>
are templates of new custom components.
<template>
<NcActionButton v-if="iLikeButtons" />
<NcActionInput v-else-if="iDont" />
</template>
<script>
export default {
name: 'MyAction'
}
</script>
and then
<template>
<NcActions>
<MyAction />
</NcActions>
</template>
Yes, this didn't work at all with |
I have found a small number of apps that require this feature. Text, Mail. I hope, we will find a solution until they migrate =D |
100% translated source file: 'l10n/messages.pot' on 'ar'.
…9836fb49eeb7494eb2c87d1dac
Ok, I would propose that we do a simple merge of |
2196317
to
514bbe1
Compare
Since |
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
3fd970e
to
e638b3e
Compare
☑️ Resolves
master
intonext
.@ShGKme I didn't get #5178 to work properly with vue 3 yet. This needs some more work.