-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: regression in list item's extra slot #5250
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
The "after" image also looks broken, for the |
this is fixed on mail side, i already pushed a pr for that nextcloud/mail#9336 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes reverting a11y fixes and are not valid -> must not be done. You have to find a solution with the actions outside the anchor element
@@ -394,21 +394,20 @@ | |||
</div> | |||
</div> | |||
</div> | |||
<!-- Actions --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must not be done! An interactive element (the a
) must not contain any other interactive element (the NcActions
).
We changed this just a couple of weeks ago.
Was there a design review? It seems this component gets extended to an all-in-one-solution. |
Makes more sense now thank you for the explanation, I'll try to work on a different solution |
I mean if it fits in the component fine, but we can not have nested interactive elements. This only works with some specific focus handling (e.g. how menu bars work, you can tab the first element but next tab will be outside the menu bar, you then need to use arrows to change focus). |
☑️ Resolves
🖼️ Screenshots
🚧 Tasks
🏁 Checklist
next
requested with a Vue 3 upgrade