New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[next] fix(NcCheckboxRadioSwitch): Pass attrs to input
if available
#5508
Open
backportbot
wants to merge
1
commit into
next
Choose a base branch
from
backport/5507/next
base: next
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
added
bug
Something isn't working
3. to review
Waiting for reviews
feature: checkbox-radio-switch
Related to the checkbox-radio-switch component
labels
Apr 20, 2024
On vue3 this requires special handling, as |
susnux
force-pushed
the
backport/5507/next
branch
from
April 20, 2024 20:29
b906971
to
9c951c1
Compare
susnux
approved these changes
Apr 20, 2024
ShGKme
reviewed
Apr 21, 2024
susnux
force-pushed
the
backport/5507/next
branch
3 times, most recently
from
April 22, 2024 13:06
21ae8f6
to
e361276
Compare
ShGKme
reviewed
Apr 22, 2024
susnux
force-pushed
the
backport/5507/next
branch
from
April 22, 2024 20:56
e361276
to
c31eef3
Compare
susnux
force-pushed
the
backport/5507/next
branch
from
April 22, 2024 21:08
c31eef3
to
a16f5ec
Compare
If not button type, pass the attrs to the input element to allow setting aria tags like `aria-invalid` and `aria-errormessage` Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
backport/5507/next
branch
from
April 22, 2024 21:09
a16f5ec
to
c868c41
Compare
@ShGKme anything more needed? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
bug
Something isn't working
feature: checkbox-radio-switch
Related to the checkbox-radio-switch component
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5507
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.