Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.diffplug.spotless from 6.12.0 to 6.12.1 #39

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 3, 2023

Bumps com.diffplug.spotless from 6.12.0 to 6.12.1.

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies automated dependency updates label Jan 3, 2023
updated-dependencies:
- dependency-name: com.diffplug.spotless
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky tobiasKaminsky force-pushed the dependabot/gradle/com.diffplug.spotless-6.12.1 branch from f7bebff to 14e14eb Compare January 4, 2023 09:29
@tobiasKaminsky tobiasKaminsky self-requested a review January 4, 2023 09:29
@tobiasKaminsky
Copy link
Member

@AlvaroBrey @mahibi @timkrueger I am not sure if I like this…

@AlvaroBrey
Copy link
Member

I am not sure if I like this…

Does ktlint apply trailing commas by default now?

My opinion is that it's a bit ugly but it's worth it because it keeps diffs simpler when arguments are added, removed or moved around. So I have no strong feelings one way or the other.

@AlvaroBrey
Copy link
Member

AlvaroBrey commented Jan 8, 2023

Trailing commas at declaration site are recommended by the Kotlin style guide, though: https://kotlinlang.org/docs/coding-conventions.html#trailing-commas

But I would disable them in call sites, that creates too much noise and the benefits aren't as clear.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 16, 2023

A newer version of com.diffplug.spotless exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@AlvaroBrey AlvaroBrey closed this Jan 16, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 16, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/gradle/com.diffplug.spotless-6.12.1 branch January 16, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies automated dependency updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants