Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @fullcalendar/* from 4.3.0 to 5.0.0 beta #2196

Closed

Conversation

georgehrke
Copy link
Member

@georgehrke georgehrke commented Apr 17, 2020

Plenty of features (#26, #30, #39, #152, #1844) for the next 2.1 Milestone are closely related to FullCalendar. So instead of implementing them for FullCalendar 4 and then having to redo a lot of the work for FullCalendar 5, i would like to update to FullCalendar 5 first.

According to https://fullcalendar.io/blog/2020/04/v5-beta-released, the final release will be Early or Mid May.

ToDo

  • Implement new hooks, many of our current hooks are broken
  • Fix CSS
  • probably more ...

With FullCalendar 5, box-sizing: border-box becomes the standard in fc, so updating will also fix #1815 :)

@georgehrke georgehrke added the 2. developing Work in progress label Apr 17, 2020
@georgehrke georgehrke changed the title Bump @fullcalendar/* from 4.3.0 to 5.0.0 Bump @fullcalendar/* from 4.3.0 to 5.0.0 beta Apr 17, 2020
@codecov-io
Copy link

codecov-io commented Apr 17, 2020

Codecov Report

Merging #2196 into master will increase coverage by 64.04%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2196       +/-   ##
=============================================
+ Coverage     30.36%   94.41%   +64.04%     
  Complexity      103      103               
=============================================
  Files           146        7      -139     
  Lines          5354      394     -4960     
  Branches        802        0      -802     
=============================================
- Hits           1626      372     -1254     
+ Misses         3728       22     -3706     
Flag Coverage Δ Complexity Δ
#javascript ? ?
#php 94.41% <ø> (ø) 103.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...components/Editor/Repeat/RepeatFirstLastSelect.vue
src/views/EditSidebar.vue
src/components/Editor/Repeat/RepeatSummary.vue
src/components/AppNavigation/Settings.vue
...ents/Editor/Invitees/AvatarParticipationStatus.vue
src/models/calendarObject.js
src/filters/dateRangeFormat.js
src/components/Shared/TimePicker.vue
...ents/Editor/Properties/PropertyTitleTimePicker.vue
src/utils/color.js
... and 107 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a62fa29...f8c020e. Read the comment docs.

@georgehrke
Copy link
Member Author

Sudden build errors most likely related to an upstream change: fullcalendar/fullcalendar#5467

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke force-pushed the dependageorg/npm_and_yarn/fullcalendar_5beta branch from fa3458f to f8c020e Compare August 19, 2020 05:42
@georgehrke georgehrke mentioned this pull request Aug 22, 2020
6 tasks
@georgehrke
Copy link
Member Author

Replaced by #2498

@georgehrke georgehrke closed this Aug 22, 2020
@georgehrke georgehrke deleted the dependageorg/npm_and_yarn/fullcalendar_5beta branch August 22, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
2 participants