Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EmojiPicker): allow to unselect collective and page emoji #907

Merged
merged 1 commit into from Sep 26, 2023

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Sep 26, 2023

Fixes: #422

Requires nextcloud-libraries/nextcloud-vue#4575

馃弫 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good... even tests included and covering both pages and collectives.
馃挴 馃榾

Just one small comment.

src/components/Page.vue Outdated Show resolved Hide resolved
Fixes: #422

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- marked this pull request as ready for review September 26, 2023 20:35
@mejo- mejo- merged commit 49a134f into main Sep 26, 2023
35 of 38 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/unselect_emoji branch September 26, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing bug Something isn't working ui/ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to remove the emoji of a page
2 participants