Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't filter results while sharing #3782

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

avinash-0007
Copy link

@avinash-0007 avinash-0007 commented Jan 12, 2024

  • Share only works by display name right now

  • Search by email to share calendar is broken completely as there is a filterBy option in vue-select whose return value defaults to return (label || '').toLocaleLowerCase().indexOf(search.toLocaleLowerCase()) > -1

    • label in our code is set to displayName so only search by displayName works
  • Since we already get our results by searching(DAV & OCS), I don't see why we need the filterBy option in the first place

    • So I just make the return value true
    • In case we do need the option, we should make it check for both displayName and email attributes

same as this PR : nextcloud/calendar#5645

@hamza221
Copy link
Contributor

hamza221 commented Apr 2, 2024

@avinash-0007 thank you for your contribution, Can you make sure to sign off the commit, to have a green CI

@hamza221 hamza221 self-requested a review April 2, 2024 08:32
@hamza221 hamza221 added bug Something isn't working 3. to review Waiting for reviews regression Regression of a previous working feature labels Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants