Add browser notification support to timers #1409
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR/issue depends on:
|
Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
MarcelRobitaille
force-pushed
the
1064-notifications
branch
from
2cfc64e
to
2a63121
Compare
- Only request permission when the timer is started. Don't be annoying if the user isn't even going to use the feature - Add a justification for why the permission is requested and how to disable the notifications - Handle case of no browser notification support - Move all desktop notification related code into its own file Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1064
In addition to showing a popup dialog, also send a browser notification.
I am also working on a UI to enable/disable different alert methods as discussed in #1064. I am also working on Nextcloud / push notifications as discussed in #1129. I wonder if these could be rolled in here.
I think the UI to enable/disable alert methods could be its own issue that depends on #1064 and #1129, but maybe these shouldn't be published in a release until the possibility to turn them off is added. What do you think?