Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RecipeView.vue #2236

Merged
merged 4 commits into from
May 31, 2024
Merged

Update RecipeView.vue #2236

merged 4 commits into from
May 31, 2024

Conversation

philiprenich
Copy link
Contributor

Fix grid layout causing large white space

  • Allow rows to be auto sized
  • Use gap instead of an extra column
  • Adjust row & column as necessary

Topic and Scope

These changes to the grid layout will remove the excess white space on the recipe view, especially for small screens.

Concerns/issues

Due to Vue's scoped styles, this should not affect anything else.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
    • CSS only change. But apologies regardless as I have not set up a dev env for Nextcloud yet.
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@christianlupus
Copy link
Collaborator

@seyfeb does this collide with your work currently?

@seyfeb
Copy link
Collaborator

seyfeb commented Apr 16, 2024

@seyfeb does this collide with your work currently?

Definitely, as I touched almost everything in the frontend. At least, in the RecipeView I moved things around a lot. However, it might take some weeks until my changes are finalized, so if you want to push out a new release with the updated style included, it would be okay, I guess.

Copy link

github-actions bot commented May 1, 2024

Test Results

   12 files    584 suites   1m 32s ⏱️
  573 tests   573 ✅ 0 💤 0 ❌
2 292 runs  2 291 ✅ 1 💤 0 ❌

Results for commit b3b4c08.

♻️ This comment has been updated with latest results.

Fix grid layout causing large white space
- Allow rows to be auto sized
- Use `gap` instead of an extra column
- Adjust row & column as necessary

Signed-off-by: Philip Renich <hello@philiprenich.com>
philiprenich and others added 3 commits May 30, 2024 14:39
Signed-off-by: Philip Renich <hello@philiprenich.com>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Philip Renich <hello@philiprenich.com>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus merged commit 01a17a7 into nextcloud:master May 31, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants