Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new method for changelog handling #2291

Merged
merged 18 commits into from
May 20, 2024

Conversation

christianlupus
Copy link
Collaborator

@christianlupus christianlupus commented May 4, 2024

Topic and Scope

Closes #2021

This will provide a way to simplify updates to the changelog. In fact the dev is only required to careate an individual file per PR.

Concerns/issues

Some things to consider

  • Update the workflow script to look for the changlog snippet
  • Document the process for authors
  • Migrate the main-0.10.x branch
  • Update the deployment scripts

There is still the open question on how to handle the chronological ordering of the releases (0.10.6 can come after 0.11.0). Should this be respected in the changelog building process? How is this to be stored?

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

I did not change the code base itself, so no issues here.

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.09%. Comparing base (8cdf846) to head (cea932a).
Report is 80 commits behind head on master.

Current head cea932a differs from pull request most recent head 9ec9e08

Please upload reports for the commit 9ec9e08 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2291   +/-   ##
=======================================
  Coverage   80.09%   80.09%           
=======================================
  Files          92       92           
  Lines        2653     2653           
=======================================
  Hits         2125     2125           
  Misses        528      528           
Flag Coverage Δ
integration 21.40% <ø> (ø)
migration 5.69% <ø> (ø)
unittests 57.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Christian Wolf <github@christianwolf.email>
Copy link

github-actions bot commented May 4, 2024

Test Results

   12 files    572 suites   1m 32s ⏱️
  552 tests   552 ✅ 0 💤 0 ❌
2 208 runs  2 207 ✅ 1 💤 0 ❌

Results for commit 9ec9e08.

♻️ This comment has been updated with latest results.

@christianlupus christianlupus self-assigned this May 14, 2024
@christianlupus
Copy link
Collaborator Author

Question for you, @seyfeb:
Do you think it is a required/good practice to create a common CHANGELOG (i.e. the CHANGELOG.md in the master branch) for all releases created (also the ones residing in the other branches like the main-0.10.x)? Currently, the CHANGELOG is distributed over the branches. Would it bring a significant benefit to have a single CHANGELOG file in the master branch?

@seyfeb
Copy link
Collaborator

seyfeb commented May 14, 2024

Question for you, @seyfeb: Do you think it is a required/good practice to create a common CHANGELOG (i.e. the CHANGELOG.md in the master branch) for all releases created (also the ones residing in the other branches like the main-0.10.x)? Currently, the CHANGELOG is distributed over the branches. Would it bring a significant benefit to have a single CHANGELOG file in the master branch?

I don't think it would provide much benefit to put all the changes of different branches in a CHANGELOG file on the master branches. Combining the changes from all branches into a single changelog file on the main branch might even lead to confusion since it does not actually contain changes on the master branch as one would expect.

@christianlupus christianlupus force-pushed the maintenance/update-changelog-method branch 17 times, most recently from aaa4b56 to f194aaa Compare May 18, 2024 18:32
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus force-pushed the maintenance/update-changelog-method branch from f194aaa to 2164291 Compare May 18, 2024 18:50
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Add a hint on the new process and add lost changelog snippet

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus marked this pull request as ready for review May 19, 2024 17:12
@christianlupus
Copy link
Collaborator Author

/approve

Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@christianlupus
Copy link
Collaborator Author

This PR needs a companion PR (for the main-0.10.x branch) that I need to prepare before processing further.

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus merged commit ef640fb into master May 20, 2024
32 checks passed
@christianlupus christianlupus deleted the maintenance/update-changelog-method branch May 20, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the changelog process
3 participants