-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new method for changelog handling #2291
Conversation
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2291 +/- ##
=======================================
Coverage 80.09% 80.09%
=======================================
Files 92 92
Lines 2653 2653
=======================================
Hits 2125 2125
Misses 528 528
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Christian Wolf <github@christianwolf.email>
Test Results 12 files 572 suites 1m 32s ⏱️ Results for commit 9ec9e08. ♻️ This comment has been updated with latest results. |
Question for you, @seyfeb: |
I don't think it would provide much benefit to put all the changes of different branches in a CHANGELOG file on the master branches. Combining the changes from all branches into a single changelog file on the main branch might even lead to confusion since it does not actually contain changes on the |
aaa4b56
to
f194aaa
Compare
Signed-off-by: Christian Wolf <github@christianwolf.email>
f194aaa
to
2164291
Compare
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Add a hint on the new process and add lost changelog snippet Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automatically approved by GitHub action on behalf of /approve
This PR needs a companion PR (for the |
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Topic and Scope
Closes #2021
This will provide a way to simplify updates to the changelog. In fact the dev is only required to careate an individual file per PR.
Concerns/issues
Some things to consider
main-0.10.x
branchThere is still the open question on how to handle the chronological ordering of the releases (0.10.6 can come after 0.11.0). Should this be respected in the changelog building process? How is this to be stored?
Formal requirements
There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.
I did not change the code base itself, so no issues here.