fix(configuration): [reverse proxy] Correct errors in Multiple domains reverse SSL proxy example
#11638
Conversation
The ' was missing. Maybe the url off the ssl proxy also? Signed-off-by: Martin Brossmann <github@brossmann.eu>
| @@ -167,7 +167,7 @@ you can set the following parameters inside the :file:`config/config.php`. | |||
| 'overwriteprotocol' => 'https', | |||
| 'overwritewebroot' => '/domain.tld/nextcloud', | |||
| 'overwritecondaddr' => '^10\.0\.0\.1$', | |||
| 'overwrite.cli.url' => 'https://domain.tld/, | |||
| 'overwrite.cli.url' => 'https://ssl-proxy.tld/domain.tld/', | |||
There was a problem hiding this comment.
| 'overwrite.cli.url' => 'https://ssl-proxy.tld/domain.tld/', | |
| 'overwrite.cli.url' => 'https://ssl-proxy.tld/domain.tld/nextcloud', |
There was a problem hiding this comment.
This is the URL used when emails are sent. I'm not sure you want ssl-proxy.tld to be part of that? Actually I would assume exactly the opposite?
There was a problem hiding this comment.
I wonder how relevant the above example block is nowadays.
The time that someone would actually use a ssl proxy because the certificates are too expensive is long over.
We should probably remove the section because people confuse it with reverse proxies used today.
There was a problem hiding this comment.
See my more elaborated answer: #9466 (comment)
joshtrichards
changed the title
Multiple domains reverse SSL proxy example
|
/backport to stable28 |
|
/backport to stable27 |
|
/backport to stable26 |
|
Thanks 👍 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
The ' was missing. Maybe the url off the ssl proxy also?