Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for domain change #11732

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sommerwiesel
Copy link

Add instructions for a domain change.

☑️ Resolves

  • Gives users instructions on how to perform a domain change
  • I have fully tested the method on my production nextcloud with many many apps and many many fiiles and there are no problems

Add instructions for a domain change.

Signed-off-by: Marvin Zurborg <106014757+Sommerwiesel@users.noreply.github.com>
@joshtrichards
Copy link
Member

Hi @Sommerwiesel - Thanks for the addition! I agree it's easy enough to add/change domains by merely adding them to trusted_domains, but I'm not sure about this because it gets more complicated when client apps are involved as well as for some server-side apps.

Server-side apps: Some will break and require re-configuration or config resets. social (requires a full config reset), notify_push (if not configured to use config.php), and richdocuments (if used with richdocumentscode) come to mind. Possibly some of the authentication apps. On the other hand, that's always the case I suppose and we can't cover all apps/scenarios. Plus admin's should expect there will be other spots they need to change domain references I guess (theming and spreed/talk?).

Clients (desktop, mobile): Will not accept a domain change. New account profiles must get created. Data will have to be re-synced. Profile options will have to be re-entered.

Also, AFAIK even with redirects in place existing shares will break (same as when multiple distinct domains are in-use I presume - #11623).

I just don't want to mislead people that it's just that easy since it's more along the lines of it might be easy, but it depends. :-)

Which doesn't mean we can't document precisely that I guess. 🤔

Those are my initial thoughts.

@joshtrichards joshtrichards changed the title Update domain_change.rst Instructions for domain change Apr 25, 2024
@kesselb
Copy link
Contributor

kesselb commented Apr 25, 2024

I changed the domain for my Nextcloud instance a while ago and found the domain name a couple of times in the database. phpMyAdmin's search feature was really helpful back then.

image

The domain name is used in oc_circles_event (instance name) and oc_circles_member (note) at least.

@szaimen
Copy link
Contributor

szaimen commented Apr 25, 2024

The domain name is used in oc_circles_event (instance name) and oc_circles_member (note) at least.

There are even more places, e.g. look here: https://github.com/nextcloud/all-in-one?tab=readme-ov-file#how-to-change-the-domain

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants