Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin_manual): Explicitly specify which versions of MySQL #11801

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joshtrichards
Copy link
Member

☑️ Resolves

Rather than say "8.0+" (which could lead to problems with deployments using untested versions of MySQL with Nextcloud) let's stick to the actual versions we test against.

Currently (in master) that is, technically 8.0 and 8.3, but not the recently published 8.4. We are explicit with our other recommended databases so let's be consistent here too.

Included 8.2 since, like for PostgreSQL, our automated test matrix skips it for efficiency (presumably) since it likely is covered by our 8.0 and 8.3 tests (it's out of scope to debate the pros/cons of that here).

🖼️ Screenshots

New:
image

Existing:
image

…gested

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
| | - openSUSE Leap 15.5 |
| | - CentOS Stream |
+------------------+------------------------------------------------------------------------------------+
| Database | - **MySQL** **8.0**/8.2/8.3 or MariaDB 10.3/10.5/**10.6**/10.11 (recommended) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.2 is EOL since 3 month.

| | - openSUSE Leap 15.5 |
| | - CentOS Stream |
+------------------+------------------------------------------------------------------------------------+
| Database | - **MySQL** **8.0**/8.2/8.3 or MariaDB 10.3/10.5/**10.6**/10.11 (recommended) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should only list the LTS version 8.0 and 8.4 (and add 8.4 to our testing matrix).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The (recommended) was inline, to clarify that we recommend the 10.6 instead of any mysql/mariadb
But it seems that got lost already for mysql on the last bump. So let's hope the bolding is enough.

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants