fix: pin sphinx-rtd-theme to fix missing jquery lib #9542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JQuery was removed as of Sphinx 6. The maintainers of our theme already reacted to this but the release is not final yet. Ref sphinx-doc/sphinx#10070 Ref readthedocs/sphinx_rtd_theme#1385 Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
added
bug
3. to review
regression
dependencies
ChristophWurst
approved these changes
Jan 11, 2023
|
If we pin versions it would probably make sense to configure Dependabot for the pipfile |
We shouldn't wait much longer with a broken search. It's hurting our users and admins as well as anyone helping answer their questions |
|
I guess backport is needed as well ? if yes please request them |
|
Search works in 22 and older |
|
/backport to stable25 |
|
/backport to stable24 |
|
/backport to stable23 |
This was referenced Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JQuery was removed as of Sphinx 6. The maintainers of our theme already reacted to this but the release is not final yet.
Ref sphinx-doc/sphinx#10070
Ref readthedocs/sphinx_rtd_theme#1385
Alternative
We could also wait until sphinx-rtd-theme v1.2 is released.