Make log levels button keyboard focusable and activable #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fenn-CS
requested review from
icewind1991,
Valdnet,
susnux and
szaimen
and removed request for
icewind1991
Antreesy
reviewed
Jun 21, 2023
Fenn-CS
force-pushed
the
36985-log-levels-button-focusable
branch
from
5689e15
to
78ec405
Compare
|
/compile amend |
nextcloud-command
force-pushed
the
36985-log-levels-button-focusable
branch
from
78ec405
to
5c53387
Compare
Fenn-CS
force-pushed
the
36985-log-levels-button-focusable
branch
2 times, most recently
from
92a81f5
to
93cb343
Compare
|
Thanks @Antreesy resolved the mentioned issues, and manual compiled (before seeing you did the compile command already) |
|
/compile amend |
|
Looks like runner doesn't like manual build, let's try the command again: |
nextcloud-command
force-pushed
the
36985-log-levels-button-focusable
branch
from
93cb343
to
d3d3eed
Compare
Antreesy
reviewed
Jun 21, 2023
src/Components/LogTable.css.d.ts
Outdated
| highlight: string; | ||
| level: string; | ||
| level_1: string; | ||
| level_2: string; |
There was a problem hiding this comment.
Please check that also: property 'focus-within' or 'focus-visible' was removed, but file still has changes due to indent (tabs or spaces?)
icewind1991
approved these changes
Jun 21, 2023
Fenn-CS
force-pushed
the
36985-log-levels-button-focusable
branch
from
d3d3eed
to
b56edf7
Compare
|
|
/compile amend |
nextcloud-command
force-pushed
the
36985-log-levels-button-focusable
branch
from
b56edf7
to
fcccb50
Compare
Antreesy
approved these changes
Jun 22, 2023
Fenn-CS
force-pushed
the
36985-log-levels-button-focusable
branch
2 times, most recently
from
87af507
to
d40a797
Compare
|
/compile amend |
nextcloud-command
force-pushed
the
36985-log-levels-button-focusable
branch
from
d40a797
to
e2f07d7
Compare
Fenn-CS
force-pushed
the
36985-log-levels-button-focusable
branch
from
e2f07d7
to
dbb3feb
Compare
|
/compile amend |
Improves accessibility by activating focus visible and making the log level button trigger-able from the keyboard as well. Since both the text and the icons trigger the same action, both of them were wrapped in a button to make this easier. Resolves: nextcloud/server#36985 Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
36985-log-levels-button-focusable
branch
from
dbb3feb
to
41813ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves accessibility by activating focus visible and making the log level button trigger-able from the keyboard as well.
Since both the text and the icons trigger the same action, both of them were wrapped in a button to make this easier.
Resolves: nextcloud/server#36985
Previews