Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styled "Add mail account" button with properties of NcButton. #8751

Closed
wants to merge 1 commit into from

Conversation

auroraanna
Copy link
Contributor

@auroraanna auroraanna commented Aug 15, 2023

@auroraanna auroraanna changed the title Tried to style "Add mail account" button with properties of NcButton. Styled "Add mail account" button with properties of NcButton. Aug 15, 2023
@auroraanna auroraanna self-assigned this Aug 15, 2023
@auroraanna
Copy link
Contributor Author

The new aligment property of the NcButton component released in 7.12.2 of nextcloud/vue doesn't seem to be working. The "Add mail account" button is still aligned center, not start.

@auroraanna auroraanna force-pushed the fix/8714/add-mail-account-button-styling branch from a32f87e to fdae363 Compare August 15, 2023 10:16
@GretaD
Copy link
Contributor

GretaD commented Aug 15, 2023

Turns out this: nextcloud-libraries/nextcloud-vue#4366

is not released yet

@auroraanna
Copy link
Contributor Author

auroraanna commented Aug 18, 2023

Hmm, now that commit was released in 8.0.0-beta.3 but the Multiselect component is missing, causing the build to fail.

Signed-off-by: Anna Aurora <anna@annaaurora.eu>
@auroraanna auroraanna force-pushed the fix/8714/add-mail-account-button-styling branch from fdae363 to 2bbbdcc Compare August 18, 2023 14:43
@ChristophWurst ChristophWurst mentioned this pull request Nov 29, 2023
24 tasks
@ChristophWurst
Copy link
Member

Stale and conflicts. We have to redo this

@ChristophWurst ChristophWurst deleted the fix/8714/add-mail-account-button-styling branch February 23, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Add mail account" button looks wonky
3 participants