Scan photos of specific directory

[tetebueno]

I've been getting memory exhaustion when scanning all photos collection on an initial load; trying to address #525 I made these changes and was able to scan each year/month directory of photos succesfully like this (the example is for the folder with photos of july '84):

$ docker exec -t -u www-data container-name php occ maps:scan-photos -vvv username Photos/1984/06

I didn't like the ifs all over the implementation, but it's something like a make it work approach. If I can get comments about it, we can make it better.

Cheers.

[tacruc]

Thanks for your contribution. Can you pass the path as optional argument?
Do you need help to fix the DCO?

[tetebueno]

You are very welcome.

Done with DCO, thanks.

Is there anything else besides this so the path parameter is optional? I believe it already is since help command displays it like this: ... [<user_id> [<path>]].

[tacruc]

Hi @tetebueno,
sorry for the late reply and beeing a little unprecise.
I mean in stead of adding the functions
RescanPhotos->scanUserPhotos
and
PhotofilesService->rescanPath

Just provide an optional parameter to

       private function rescanUserPhotos(string $userId, bool $inBackground=true, sting? $pathToScan===null) {

and PhotofilesService
public function rescan($userId, $inBackground=true, $pathToScan=null) {

and then make an if in the Photofilesservice->rescan

$userFolder = $this->root->getUserFolder($userId)
if ($pathToScan === null) {
          $folder = $userFolder
} else {
          $folder = $userFolder->get($pathToScan);
}
$photos = $this->gatherPhotoFiles($folder, true);

Don't blindly copy my code. It is just typed in here to outline my thought and not tested.

[tacruc]

Suggested change

	if ($pathToScan === null) {
	$this->rescanUserPhotos($user->getUID(), $inBackground, pathToScan);

[tacruc]

Suggested change

	if ($pathToScan === null) {
	$this->rescanUserPhotos($userId, $inBackground);
	} else {
	$this->scanUserPhotos($userId, $pathToScan, $inBackground);
	}
	$this->rescanUserPhotos($userId, $inBackground, pathToScan);

[tacruc]

@tetebueno Do you think you will make the changes befor the NC29 release. Then I would wait with #1244 to include this.

I'm sorry that it is on such short notice after not reviewing for a month. Just have to decide whether to wait or not.