Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): Activate add button with voice input #2013

Closed
wants to merge 2 commits into from
Closed

Conversation

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove using default value for ariaLabel in NcActions when menuTitle is present?

@Pytal
Copy link
Member Author

Pytal commented Aug 22, 2023

Should we remove using default value for ariaLabel in NcActions when menuTitle is present?

Since v8 is still in beta we can break things :D, so let's go with that!

@Pytal
Copy link
Member Author

Pytal commented Aug 22, 2023

@Pytal
Copy link
Member Author

Pytal commented Aug 24, 2023

PR merged

Superseded by bump

@Pytal Pytal closed this Aug 24, 2023
@Pytal Pytal deleted the fix/a11y-label branch August 24, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants