Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adapt to new NcEmptyContent usage #2974

Merged
merged 1 commit into from May 30, 2023
Merged

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented May 30, 2023

Bring back the proper loading/error empty content view on loading

was breaking in https://github.com/nextcloud/nextcloud-vue/releases/tag/v7.0.0

Will need another update with 8.x nextcloud-libraries/nextcloud-vue#4106

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@cypress
Copy link

cypress bot commented May 30, 2023

Passing run #303 ↗︎

0 25 0 0 Flakiness 0

Details:

fix: Adapt to new NcEmptyContent usage
Project: Richdocuments Commit: e36f2ad5b5
Status: Passed Duration: 02:49 💡
Started: May 30, 2023 10:37 AM Ended: May 30, 2023 10:40 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliushaertl juliushaertl added bug Something isn't working 3. to review Ready to be reviewed backport-request labels May 30, 2023
Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I have one question.
Approving anyway. Feel free to merge after checking / addressing the question. :)

src/view/Office.vue Outdated Show resolved Hide resolved
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl merged commit ed71bf0 into main May 30, 2023
34 of 35 checks passed
@juliushaertl juliushaertl deleted the bugfix/noid/loading branch May 30, 2023 12:26
@juliushaertl
Copy link
Member Author

/backport to stable27

@juliushaertl
Copy link
Member Author

/backport to stable26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants