Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV] 9.4.1.2/2.2 - The "Weather" menu (see screenhot) has been implemented using the aria-haspopup="menu" attribute, which informs users that a menu is being opened.(1) #41889

Closed
JuliaKirschenheuter opened this issue Nov 29, 2023 · 1 comment · Fixed by nextcloud-libraries/nextcloud-vue#4887
Closed

[BITV] 9.4.1.2/2.2 - The "Weather" menu (see screenhot) has been implemented using the aria-haspopup="menu" attribute, which informs users that a menu is being opened.(1) #41889

JuliaKirschenheuter opened this issue Nov 29, 2023 · 1 comment · Fixed by nextcloud-libraries/nextcloud-vue#4887
Assignees
@ShGKme
Labels
3. to review Waiting for reviews a11y28checked needed for a11y accessibility

Comments

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Nov 29, 2023 •
edited

However, even though the menu items can be navigated using arrow keys, the corresponding ARIA roles role="menu" and role="menuitem" are completely missing.

image

https://report.bitvtest.de/default-en/cbedb5ef-4815-4cba-a83d-995599c178c3.html#checkpoint-bfbf07e5c3-v2-n2
@JuliaKirschenheuter JuliaKirschenheuter added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap 1. to develop Accepted and waiting to be taken care of accessibility and removed enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Nov 29, 2023
@JuliaKirschenheuter JuliaKirschenheuter changed the title [BITV] 9.4.1.2/2.2 - The "Weather" menu (see screenhot) has been implemented using the aria-haspopup="menu" attribute, which informs users that a menu is being opened. However, even though the menu items can be navigated using arrow keys, the corresponding ARIA roles role="menu" and role="menuitem" are completely missing. (1) [BITV] 9.4.1.2/2.2 - The "Weather" menu (see screenhot) has been implemented using the aria-haspopup="menu" attribute, which informs users that a menu is being opened.(1) Nov 29, 2023
@ShGKme
Copy link
Contributor

ShGKme commented Nov 29, 2023

aria-haspopup is to be fixed by nextcloud-libraries/nextcloud-vue#4887

However, "the corresponding ARIA roles role="menu" and role="menuitem" are completely missing" conflicts with the previous issue: #37099 (comment)

@ShGKme ShGKme self-assigned this Nov 29, 2023
@ShGKme ShGKme mentioned this issue Nov 29, 2023
Merged
@ShGKme ShGKme added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Nov 29, 2023
@ShGKme ShGKme reopened this Dec 11, 2023
@JuliaKirschenheuter JuliaKirschenheuter mentioned this issue Dec 14, 2023
Closed
@ShGKme ShGKme closed this as completed Jan 2, 2024
@szaimen szaimen added the a11y28checked needed for a11y label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews a11y28checked needed for a11y accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(NcActions): typo in aria-haspopup nextcloud-libraries/nextcloud-vue
3 participants
@JuliaKirschenheuter @ShGKme @szaimen