Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcActions): typo in aria-haspopup #4887

Merged
merged 1 commit into from Nov 30, 2023
Merged

fix(NcActions): typo in aria-haspopup #4887

merged 1 commit into from Nov 30, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 29, 2023 •
edited

☑️ Resolves

There was a typo, then/else is misplaced in a ternary operator.

@ShGKme
fix(NcActions): typo in aria-haspopup
10cbecc 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Nov 29, 2023
@ShGKme ShGKme added this to the 8.2.1 milestone Nov 29, 2023
@ShGKme ShGKme self-assigned this Nov 29, 2023
@ShGKme ShGKme mentioned this pull request Nov 29, 2023
Closed
@susnux susnux merged commit dae6dd9 into master Nov 30, 2023
15 checks passed
@susnux susnux deleted the fix/nc-actions--typo-in-aria-haspopup branch November 30, 2023 15:27
@susnux susnux mentioned this pull request Nov 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Pytal Pytal Pytal approved these changes

@szaimen szaimen szaimen approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: actions Related to the actions components
Projects
None yet
Milestone
8.2.1
Development

Successfully merging this pull request may close these issues.

[BITV] 9.4.1.2/9.2 - Both the "Create group" and "Rename group" buttons utilize the aria-haspopup="true" attribute, but no role="menu" and role="menuitem" roles have been applied to the elements they open. (1) [BITV] 9.4.1.2/3.2 - The "Actions" menu buttons in the table should be implemented using the aria-haspopup="menu" attribute to inform users that a menu is being opened. (2) [BITV] 9.4.1.2/2.2 - The "Weather" menu (see screenhot) has been implemented using the aria-haspopup="menu" attribute, which informs users that a menu is being opened.(1) [BITV] 9.4.1.2/2.1 - The "More apps" menu in the mobile (responsive) view has been implemented using the aria-haspopup="menu" attribute, which informs users that a menu is being opened.(10)
4 participants
@ShGKme @susnux @Pytal @szaimen