Add CSP nonce to CSS as well #16580
Closed
Add CSP nonce to CSS as well #16580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
commented
Jul 27, 2019
| @@ -22,6 +22,8 @@ | |||
| import Vue from 'vue'; | |||
| import queryString from 'query-string'; | |||
|
|
|||
| __webpack_nonce__ = btoa(OC.requestToken) | |||
There was a problem hiding this comment.
@juliushaertl @skjnldsv I assumed this was enough as we use it in other places as well... but it seems not...
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
Ok got it. it is because of the import reshuffling.... so the nonce gets set to late
There was a problem hiding this comment.
Stupid wrapping seems to be the easy fix...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
skjnldsv
reviewed
Jul 27, 2019
|
|
||
| import Vue from 'vue'; | ||
| import queryString from 'query-string'; | ||
|
|
||
| __webpack_nonce__ = btoa(OC.requestToken) |
|
Ok nevermind. We are by far not ready for this. As it doesn't allow setting
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further tightening of our CSP.
It seems we need to export the nonce now to all the webpack code that wants to inject CSS (not just chunks).