Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid a crash when a PHP extension has no version #34937

Merged
merged 2 commits into from Nov 7, 2022

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Nov 3, 2022

The signature known to our psalm is somehow wrong here, getVersion can actually return null according to php documentation and issues opened by users.
Should fix #34716

Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added the 3. to review Waiting for reviews label Nov 3, 2022
@come-nc come-nc added this to the Nextcloud 26 milestone Nov 3, 2022
@come-nc come-nc self-assigned this Nov 3, 2022
@come-nc
Copy link
Contributor Author

come-nc commented Nov 3, 2022

/backport to stable25

@come-nc
Copy link
Contributor Author

come-nc commented Nov 3, 2022

/backport to stable24

@szaimen
Copy link
Contributor

szaimen commented Nov 3, 2022

hm... Seems like psalm fails? Maybe suppress the psalm error?

@come-nc
Copy link
Contributor Author

come-nc commented Nov 3, 2022

hm... Seems like psalm fails? Maybe suppress the psalm error?

vimeo/psalm#8655 sent a fix upstream, let’s see if it gets merged quickly and we can just update, or if we have to suppress the error instead.

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@szaimen
Copy link
Contributor

szaimen commented Nov 4, 2022

hm... Seems like psalm fails? Maybe suppress the psalm error?

vimeo/psalm#8655 sent a fix upstream, let’s see if it gets merged quickly and we can just update, or if we have to suppress the error instead.

I guess lets suppress the error message then?

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@szaimen szaimen merged commit 533e180 into master Nov 7, 2022
@szaimen szaimen deleted the fix/do-not-crash-on-extension-without-version branch November 7, 2022 09:45
@szaimen
Copy link
Contributor

szaimen commented Nov 7, 2022

/backport to stable23

@szaimen
Copy link
Contributor

szaimen commented Nov 7, 2022

/backport to stable24

@faxotherapy
Copy link

faxotherapy commented Nov 10, 2023

The issue appears again under Nextcloud 27.1.3. When I visit the “Users” menu under a regular account, I've got the “An error occurred during the request. Unable to proceed” message, which does not show up under my admin account.

This happens when I set “Group admim for” for a regular user.

@come-nc
Copy link
Contributor Author

come-nc commented Nov 13, 2023

The issue appears again under Nextcloud 27.1.3. When I visit the “Users” menu under a regular account, I've got the “An error occurred during the request. Unable to proceed” message, which does not show up under my admin account.

This happens when I set “Group admim for” for a regular user.

This has nothing to do with this pull request or the related issue, please open a new issue after checking if there is already one opened.
If you do open an issue please provide related server log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Applications menu empty after fresh install of Nextcloud Server v25
4 participants