Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update @nextcloud/dialogs to 4.2.0-beta.4 for FilePicker improvments #40030

Merged
merged 2 commits into from Aug 24, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 24, 2023

Summary

🚀 Enhancement

  • Add icons for filepicker and allow reactive button based on current path and selection #942 (@susnux)
  • Always show file extension as a trailing text part #933 (@susnux)
  • Show empty content when there are no files in folder #932 (@susnux)

🐛 Fixed bugs

  • Fix properties of the new button in the breadcrumbs #928 (@susnux)
  • Ensure focus-visible outline is visible for all focusable elements #936 (@susnux)
  • The table height should be max. 100% #922 (@susnux)
  • Fix exported typings and cleanup file picker files #907 (@susnux)
  • Fix typedoc generation and improve documentation of exported member #909 (@susnux)

Checklist

@susnux susnux added this to the Nextcloud 27.1.0 milestone Aug 24, 2023
@susnux susnux requested review from skjnldsv, a team, artonge and Pytal and removed request for a team August 24, 2023 10:05
…rovments

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/update-dialogs-to-4.2.0-beta.4 branch from caa503f to 66fc35f Compare August 24, 2023 10:06
@susnux susnux added the 3. to review Waiting for reviews label Aug 24, 2023
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/update-dialogs-to-4.2.0-beta.4 branch from 887508e to 84493b1 Compare August 24, 2023 10:12
@susnux
Copy link
Contributor Author

susnux commented Aug 24, 2023

Preview:
image

(Well better than the current version, but already found a bug for next beta 😢 )

@susnux
Copy link
Contributor Author

susnux commented Aug 24, 2023

Oh yeah and the buttons do now show the current directory when moving / copying:

image

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to merge from my side. Improvements can still follow.

@susnux susnux mentioned this pull request Aug 24, 2023
4 tasks
@skjnldsv skjnldsv merged commit 480d2c2 into stable27 Aug 24, 2023
37 of 38 checks passed
@skjnldsv skjnldsv deleted the fix/update-dialogs-to-4.2.0-beta.4 branch August 24, 2023 11:00
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish 🍁 2023-Autumn
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants