fix: encode uri for trashbin delete (the second one) #41176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
a team,
ArtificialOwl,
icewind1991,
sorbaugh and
Pytal
and removed request for
a team,
ArtificialOwl,
icewind1991 and
skjnldsv
This comment was marked as resolved.
This comment was marked as resolved.
Pytal
approved these changes
Oct 30, 2023
kesselb
force-pushed
the
encode-uri-trashbin-delete-3
branch
2 times, most recently
from
02f0e88
to
6d8c87b
Compare
Replace d280912 with a cleaner approach. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
encode-uri-trashbin-delete-3
branch
from
6d8c87b
to
b0f9113
Compare
Merged
artonge
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #41154
Follow up for #40757
Summary
Replace d280912 with a cleaner approach.
nextcloud-libraries/nextcloud-files#794 / #40756 for 27.
TODO
Checklist