Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] Remove disputed bz2 check #43013

Merged
merged 1 commit into from Feb 2, 2024
Merged

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jan 22, 2024

Backport of PR #42821

@backportbot backportbot bot added the 3. to review Waiting for reviews label Jan 22, 2024
@backportbot backportbot bot added this to the Nextcloud 28.0.2 milestone Jan 22, 2024
@Altahrim Altahrim mentioned this pull request Jan 22, 2024
@joshtrichards joshtrichards added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 22, 2024
@joshtrichards
Copy link
Member

Someone with power will have to override for merge during freeze.

The cypress failures appear completely unrelated:

 1) Files: Move or copy files
       Can copy a file to new folder:
     AssertionError: Timed out retrying after 4000ms: Expected to find element: `[data-cy-files-list-row-name="original.txt"]`, but never found it.
      at Context.eval (webpack://nextcloud/./cypress/e2e/files/files_copy-move.cy.ts:55:38)

  2) Files: Move or copy files
       Can move a file to its parent folder:
     AssertionError: Timed out retrying after 4000ms: Expected to find content: 'No files in here' within the element: <main#app-content-vue.app-content.no-snapper> but never did.
      at Context.eval (webpack://nextcloud/./cypress/e2e/files/files_copy-move.cy.ts:116:52)

@blizzz
Copy link
Member

blizzz commented Jan 22, 2024

Not considered critical → 28.0.3

@joshtrichards
Copy link
Member

joshtrichards commented Jan 22, 2024

Not considered critical → 28.0.3

Agreed, I guess, but just a soft nudge and I'll leave it at that 😄 It's a support / user experience matter (with the setup checks) and bug triage time waster. In the docker repo alone, the addition of this check in v28 generated over 75 upvotes and 48 comments just in the past 30 days: nextcloud/docker#2118

@come-nc
Copy link
Contributor

come-nc commented Jan 23, 2024

Not considered critical → 28.0.3

Agreed, I guess, but just a soft nudge and I'll leave it at that 😄 It's a support / user experience matter (with the setup checks) and bug triage time waster. In the docker repo alone, the addition of this check in v28 generated over 75 upvotes and 48 comments just in the past 30 days: nextcloud/docker#2118

People can ignore the warning or install the module, there is nothing critical about this.

@blizzz
Copy link
Member

blizzz commented Jan 23, 2024

We had already crowded RCs on 28 after the first one, with just important considered PRs. At this stage of a release, the less the better. More, even if they look innocent, just muddy the water while the testing time is very short.

Signed-off-by: J0WI <J0WI@users.noreply.github.com>
@susnux susnux merged commit eab6b49 into stable28 Feb 2, 2024
50 checks passed
@susnux susnux deleted the backport/42821/stable28 branch February 2, 2024 16:07
@skjnldsv skjnldsv mentioned this pull request Feb 14, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants