Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PDF conversion triggered by collaborative tag events. #454

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rotdrop
Copy link
Contributor

@rotdrop rotdrop commented Mar 3, 2023

This might fix #436

Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In workflow_script, we have similar code: https://github.com/nextcloud/workflow_script/blob/master/lib/Operation.php#L131-L143

With one difference: in this PR all nodes are being cycled through and processed, in workflow_script just the first node is being taken into account. After all, it is the same file, additional nodes might link to different representations, but it is duplicating the work.

Actually I am considering to move this logic into the framework, to some Helper or Service convenience class. This would be for 27 earliest though, as we're way beyond feature freeze for 26.

Did you decide consciously for the approach of walking through all nodes?

@Uatschitchun
Copy link

Do I get the intention of this PR correct, that adding the desired tag (maybe 'toPDF') suffice to trigger conversion?
Right now this alone doesn't suffice (just tagging an existing file without touching it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flow Not Saving Selected System TAG
3 participants