Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add default values for auto-populating select menus #1122

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

feat(ui): add default values for auto-populating select menus #1122

wants to merge 14 commits into from
+322 −25

Conversation

kingmigdor
Copy link
Contributor

@kingmigdor kingmigdor commented Sep 23, 2023 •
edited

Summary

This PR adds support for the new select default values, which got announced in the Discord Docs change-log.

Testing code: https://paste.nextcord.dev/?id=1695428857407704

This is a Code Change

  • I have tested my changes.
  • I have updated the documentation to reflect the changes.
  • I have run task pyright and fixed the relevant issues.

EmreTech
EmreTech requested changes Sep 23, 2023
View reviewed changes
nextcord/components.py Outdated Show resolved Hide resolved
nextcord/components.py Outdated Show resolved Hide resolved
nextcord/ui/select/channel.py Show resolved Hide resolved
nextcord/components.py Outdated Show resolved Hide resolved
nextcord/ui/select/channel.py Outdated Show resolved Hide resolved
@EmreTech EmreTech added p: medium Priority: medium - should be worked on in the near future s: awaiting review Status: the issue or PR is awaiting reviews t: api coverage Type: api coverage - this adds code to cover the discord API labels Sep 23, 2023
@EmreTech EmreTech changed the title feat(select-defaults): Adding auto-populated select default values feat(ui): add default values for auto-populating select menus Sep 23, 2023
ooliver1
ooliver1 requested changes Sep 23, 2023
View reviewed changes
Copy link
Member

@ooliver1 ooliver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some consistency on defaults vs default_values would be nice.

nextcord/components.py Show resolved Hide resolved
teaishealthy
teaishealthy requested changes Oct 8, 2023
View reviewed changes
Copy link
Collaborator

@teaishealthy teaishealthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

versionadded directive is missing for the new arguements

EmreTech
EmreTech requested changes Oct 10, 2023
View reviewed changes
nextcord/components.py Show resolved Hide resolved
nextcord/ui/select/mentionable.py Outdated Show resolved Hide resolved
nextcord/ui/select/channel.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ooliver1 ooliver1 Awaiting requested review from ooliver1

@teaishealthy teaishealthy Awaiting requested review from teaishealthy

@EmreTech EmreTech Awaiting requested review from EmreTech

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
p: medium Priority: medium - should be worked on in the near future s: awaiting review Status: the issue or PR is awaiting reviews t: api coverage Type: api coverage - this adds code to cover the discord API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kingmigdor @ooliver1 @EmreTech @teaishealthy