Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing fields for stage instance #1132

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Soheab
Copy link
Contributor

@Soheab Soheab commented Oct 1, 2023

Summary

This PR adds some missing fields to stage instance.

Adds the following to StageChannel.create_instance:

  • send_start_notification
  • scheduled_event

And to StageInstance:

  • scheduled_event_id
  • scheduled_event

And to HTTPClient.create_stage_instance's valid_keys:

  • send_start_notification
  • guild_scheduled_event_id

And to StageInstance (types/channel.py):

  • guild_scheduled_event_id

Relevant API Docs:
https://discord.com/developers/docs/resources/stage-instance#create-stage-instance
guild_scheduled_event_id was added recently: discord/discord-api-docs@67ce08b to create

Fixes #934

This is a Code Change

  • I have tested my changes.
  • I have updated the documentation to reflect the changes.
  • I have run task pyright and fixed the relevant issues.

@Soheab Soheab changed the title chore: add missing fields for stage instance feat(Stage-Instance): add missing fields for stage instance Oct 1, 2023
@EmreTech EmreTech changed the title feat(Stage-Instance): add missing fields for stage instance feat: add missing fields for stage instance Nov 8, 2023
@EmreTech EmreTech added p: medium Priority: medium - should be worked on in the near future s: awaiting review Status: the issue or PR is awaiting reviews t: api coverage Type: api coverage - this adds code to cover the discord API labels Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: medium Priority: medium - should be worked on in the near future s: awaiting review Status: the issue or PR is awaiting reviews t: api coverage Type: api coverage - this adds code to cover the discord API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add scheduled event field to creating stage instances
3 participants