Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(entitlements): add premium entitlements #1138

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

feat(entitlements): add premium entitlements #1138

wants to merge 34 commits into from

Conversation

kingmigdor
Copy link
Contributor

@kingmigdor kingmigdor commented Oct 22, 2023 •
edited

Summary

Discord recently added a feature where bots can implement their own premium versions to earn some money. This PR is adding functionality to fetch the entitlements of the users aswell as receiving the events of these. This PR also adds the interaction response type 10, which is the response to prompt the user to subscribe to the bot's premium subscription.

Testing code: https://paste.nextcord.dev/?id=1698181802920231

This is a Code Change

  • I have tested my changes.
  • I have updated the documentation to reflect the changes.
  • I have run task pyright and fixed the relevant issues.

kingmigdor and others added 30 commits October 22, 2023 01:48
@kingmigdor
feat(select-defaults): implement
85685d1
@kingmigdor
docs(select-defaults): adding user-documentation
cfff4d5
@pre-commit-ci @kingmigdor
style: auto fixes from pre-commit hooks
d2b2eba
@kingmigdor
feat(select-defaults): default_values in to_dict
c476cb0
@kingmigdor
feat(ui): SelectDefault classmethods
7a89a29
@pre-commit-ci @kingmigdor
style: auto fixes from pre-commit hooks
a485390
@kingmigdor
feat(ui): consistency for default attr
ff9dd0a
@kingmigdor
fix(ui): defaults attribute
2c5fdc2
@kingmigdor
docs(ui): updating SelectDefault docs
466e73f
@pre-commit-ci @kingmigdor
style: auto fixes from pre-commit hooks
9dca11e
@kingmigdor
docs(ui): updating auto-populated select defaults
9c07567
@pre-commit-ci @kingmigdor
style: auto fixes from pre-commit hooks
2b1d8a0
@kingmigdor
feat(entitlements): adding API-calling methods
2d0bce1
@pre-commit-ci
style: auto fixes from pre-commit hooks
3cf6f0d
@kingmigdor
revert: remove SelectDefault changes lol
998ef1c
@pre-commit-ci
style: auto fixes from pre-commit hooks
bb8bff4
@kingmigdor
feat(entitlements): adding websocket events
53860a3
@pre-commit-ci
style: auto fixes from pre-commit hooks
f7f1285
@kingmigdor
docs(entitlements): adding docs for entitlements
bc5277a
@pre-commit-ci
style: auto fixes from pre-commit hooks
deb0c30
@kingmigdor
fix(entitlements): add smth that looks important
5a4a049
@kingmigdor
feat(entitlements): adding something else that looks important
1673256
@pre-commit-ci
style: auto fixes from pre-commit hooks
a83a7ce
@kingmigdor
fix(entitlements): adding a dot
ea0a539
@pre-commit-ci
style: auto fixes from pre-commit hooks
da9d790
@kingmigdor
fix(entitlements): adding some other dots
57bb0ef
@pre-commit-ci
style: auto fixes from pre-commit hooks
a81a04b
@kingmigdor
removal(entitlements): removing Entitlement slots
b6505a5
@kingmigdor
removal(entitlements): removing SKU slots
4a33501
@kingmigdor
docs(entitlements): renaming methods and returns
48f1066
@kingmigdor kingmigdor marked this pull request as ready for review October 22, 2023 15:33
@teaishealthy teaishealthy changed the title feat(entitlements): Adding support for premium entitlements feat(entitlements): add premium entitlements Oct 30, 2023
Skelmis
Skelmis reviewed Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@Skelmis Skelmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given discords removal of some areas covered by this PR with guidance not to add them to libs I think we wait for a bit. Link

ooliver1
ooliver1 requested changes Dec 9, 2023
View reviewed changes
nextcord/entitlement.py Outdated Show resolved Hide resolved
nextcord/entitlement.py Outdated Show resolved Hide resolved
nextcord/entitlement.py Show resolved Hide resolved
nextcord/entitlement.py Show resolved Hide resolved
nextcord/enums.py Show resolved Hide resolved
@kingmigdor
Copy link
Contributor Author

Given discords removal of some areas covered by this PR with guidance not to add them to libs I think we wait for a bit. Link

They did not made significant changes to the API which makes this pr still work without any issues

@EmreTech EmreTech added p: low Priority: low - not important to be worked on s: awaiting review Status: the issue or PR is awaiting reviews t: api coverage Type: api coverage - this adds code to cover the discord API labels May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skelmis Skelmis Skelmis left review comments

@ooliver1 ooliver1 Awaiting requested review from ooliver1

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
p: low Priority: low - not important to be worked on s: awaiting review Status: the issue or PR is awaiting reviews t: api coverage Type: api coverage - this adds code to cover the discord API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kingmigdor @ooliver1 @Skelmis @EmreTech