Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(invite): add type attribute #1173

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat(invite): add type attribute #1173

wants to merge 5 commits into from
+24 −2

Conversation

spifory
Copy link
Collaborator

@spifory spifory commented Mar 22, 2024 •
edited

Summary

Implements discord/discord-api-docs#6568 by adding a type attribute to the Invite class.

This is a Code Change

  • I have tested my changes.
  • I have updated the documentation to reflect the changes.
  • I have run task pyright and fixed the relevant issues.

@spifory spifory added p: low Priority: low - not important to be worked on t: api coverage Type: api coverage - this adds code to cover the discord API s: waiting for discord status: the issue requires changes to the documentation or behaviour before it can be completed. labels Mar 22, 2024
teaishealthy
teaishealthy approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@teaishealthy teaishealthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ArjunSharda
ArjunSharda reviewed Mar 25, 2024
View reviewed changes
nextcord/enums.py Outdated Show resolved Hide resolved
ooliver1
ooliver1 reviewed Mar 25, 2024
View reviewed changes
nextcord/enums.py Outdated Show resolved Hide resolved
spifory and others added 2 commits March 25, 2024 19:57
@spifory @ArjunSharda
docs(enums): add remaning period to group_dm
4dd641f 
Co-authored-by: Arjun Sharda <77706434+ArjunSharda@users.noreply.github.com>
@spifory
docs(enums): change versionadded to 3.0
eee1507 
No more python 3.10 support, sorry guys :(
@EmreTech EmreTech added s: awaiting review Status: the issue or PR is awaiting reviews and removed s: waiting for discord status: the issue requires changes to the documentation or behaviour before it can be completed. labels May 18, 2024
@EmreTech
Copy link
Collaborator

Related Discord Docs PR was merged.

@EmreTech EmreTech marked this pull request as ready for review May 18, 2024 01:26
EmreTech
EmreTech reviewed May 18, 2024
View reviewed changes
nextcord/invite.py Outdated Show resolved Hide resolved
spifory and others added 2 commits May 18, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ooliver1 ooliver1 ooliver1 left review comments

@EmreTech EmreTech EmreTech left review comments

@ArjunSharda ArjunSharda ArjunSharda left review comments

@teaishealthy teaishealthy teaishealthy approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
p: low Priority: low - not important to be worked on s: awaiting review Status: the issue or PR is awaiting reviews t: api coverage Type: api coverage - this adds code to cover the discord API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@spifory @EmreTech @ooliver1 @teaishealthy @ArjunSharda