-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app-cmds): Implement User-Installed Apps #1181
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You likely want to take a look at discord/discord-api-docs#6723 to implement as it seems a lot is missing in this PR (I do understand this is still a draft though)
I only had implemented what I had seen as necessary to enable user installed apps, without checking what had actually changed in the change-log. I think everything from there is now implemented. |
I see that the pre-commit.ci check is failing. Is there anyway I can fix the rust compiler not being installed ? I ran |
…of User-Installed Apps
I don't believe so, I think we have to wait for a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I seem to have made this review a month ago and forgot, but anyways just some nitpicks in the code
…egration or interaction context types
…exts` kwargs Requested in a help thread on the support server: https://discord.com/channels/881118111967883295/1239072181132984331/1241102961829220474
None if integration_types is None else [IntegrationType(x) for x in integration_types] | ||
) | ||
|
||
if dm_permission is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DeprecationWarning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking this argument could be removed as it's a breaking change and the next version would be 3.0 anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested! 🎉
Co-authored-by: teaishealthy <76410798+teaishealthy@users.noreply.github.com>
Co-authored-by: Emma Terzioglu <50607143+EmreTech@users.noreply.github.com>
Summary
This PR implements the "integration_types" and "contexts" fields on app commands to support User-Installed Apps. It also deprecates the "dm_permission" parameter in all application commands, as it has been replaced by "contexts".
The PR is marked as draft because user apps are still in preview.
This is a Code Change
task pyright
and fixed the relevant issues.