Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(WidgetMember): update display_name method to include global_name #1183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kevin-OVI
Copy link
Contributor

Summary

This is a follow-up to #1123 . I had suggested to also apply that change to WidgetMember as it also has a display_name property, but that PR got merged without it.
This PR applies that same change as Member to WidgetMember : the display_name property will return the name using the following hierarchy:

  1. Guild specific nickname
  2. Global Name (also known as 'Display Name' in the Discord UI)
  3. Unique username

This is a Code Change

  • I have tested my changes.
  • I have updated the documentation to reflect the changes.
  • I have run task pyright and fixed the relevant issues.

@Skelmis
Copy link
Collaborator

Skelmis commented May 10, 2024

I feel like 2 & 3 should maybe be swapped at first look, but this is a choice for others to agree or disagree with. Consider this comment an approval if others like the current order.

@Kevin-OVI
Copy link
Contributor Author

I don't think so, this is the order used by User and Member in the original PR, and also the one used in the Discord UI.

Copy link
Collaborator

@EmreTech EmreTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looking back at it, this was actually needed in the original PR. Sorry about that!

@EmreTech EmreTech added p: low Priority: low - not important to be worked on s: awaiting review Status: the issue or PR is awaiting reviews t: enhancement Type: enhancement - new feature or request labels May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: low Priority: low - not important to be worked on s: awaiting review Status: the issue or PR is awaiting reviews t: enhancement Type: enhancement - new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants