-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove storage account name if present from azure path #4692
base: master
Are you sure you want to change the base?
feat: remove storage account name if present from azure path #4692
Conversation
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: endre-seqera <endre.sukosd@seqera.io>
aee2c56
to
fcd676f
Compare
plugins/nf-azure/src/main/nextflow/cloud/azure/file/AzPathFactory.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: endre-seqera <endre.sukosd@seqera.io>
f64509e
to
4704d95
Compare
Provided this may work, i'm bit concerned altering the container aka bucket name under the hood. This could result having nextflow reporting a different object file path compared to the one specified by the user, in the trace files, report, and other provenance record. It may be worth to add full support for it |
I understand your concern, but the bucket (container) name is not altered, only the additional information (storage account name) is removed. So object file path will still be correct, just missing this extra information. But this extra information is redundant in a way, because it is already known to the user, since the user has to configure it with their azure credentials in the
The "convention" used in SeqeraPlatform But no one is expecting azure paths in this format, and for a given, specific nextflow configuration (or for one specific credential) this information (storage account name) is not necessary. |
456c4c3
to
4704d95
Compare
Closes: #4683
Remove storage account name if present from azure path
Tests
Tested using nextflow-publishdir pipeline.
Before:
After: