-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Azure certificates compatibility #4888
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Steps to show it works: main.nf: process HELLO {
container "docker.io/redhat/ubi8:8.9"
output:
stdout
script:
"""
echo "Hello, World!"
"""
}
workflow {
HELLO()
} Config:
Command:
Output:
|
Shoot. Integration tests fail: Launching `./test-complexpaths.nf` [thirsty_bohr] DSL2 - revision: 44828720b8
[47/0ffbb5] Submitted process > foo
ERROR ~ Error executing process > 'foo'
Caused by:
Missing output file(s) `*.fa` expected by process `foo`
Command executed:
echo A > hello.txt
echo B > sample.zip
echo C > sample.html
echo D > 01_A\(R1\).fastq
echo E > 01_A\(R2\).fastq
echo F > sample_\(1\ 2\).vcf
echo 1 > f1.fa
echo 2 > f2.fa
echo 3 > f3.fa
mkdir .alpha
echo "Hello world!" > .alpha/hello.txt
Command exit status:
0
Command output:
(empty) |
validation/azure.config
Outdated
docker.runOptions = '-v /etc/ssl/certs:/etc/ssl/certs:ro -v /etc/pki:/etc/pki:ro' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also doesn't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
When running a CentOS container on a Debian based virtual machine on Azure (default), an error was thrown while mounting the certificates. This was because we tried to add them by default. This PR changes the behaviour so this no longer happens. A user can still renable these options using the `container.runOptions` as per any other Docker runner. Signed-off-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
aadb67c
to
0c3ce63
Compare
When running a CentOS container on a Debian based virtual machine on Azure (default), an error was thrown while mounting the certificates. This was because we tried to add them by default. This PR changes the behaviour so this no longer happens. A user can still renable these options using the
container.runOptions
as per any other Docker runner.Fixes #4828
Signed-off-by: Adam Talbot 12817534+adamrtalbot@users.noreply.github.com