Skip to content

Commit

Permalink
Merge pull request #428 from nextui-org/fix_427/missing-component-pop…
Browse files Browse the repository at this point in the history
…over-docs

Fix 427/missing component popover docs
  • Loading branch information
jrgarciadev committed Apr 24, 2022
2 parents b2e3160 + b6736bf commit 7d60611
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 18 deletions.
38 changes: 23 additions & 15 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,20 +1,28 @@
## [LEVEL]/[COMPONENT]
**TASK**: <!--- [Github ISSUE](Issue Link) -->
<!---
Thanks for creating a Pull Request ❤️!
Please read the following before submitting:
- PRs that adds new external dependencies might take a while to review.
- Keep your PR as small as possible.
- Limit your PR to one type (docs, feature, refactoring, ci, repo, or bugfix)
-->

### Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
Closes # <!-- Github issue # here -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Only
- [ ] Refactor
## 📝 Description

### Description, Motivation and Context
<!--- Describe your changes in detail -->
<!--- Why is this change required? What problem does it solve? -->
<!--- If it is solving an issue... How can it be reproduced in order to compare between both behaviors? -->
> Add a brief description
### Screenshots - Animations
<!-- Adding images or gif animations of your changes improves the understanding of your changes -->
## ⛳️ Current behavior (updates)

> Please describe the current behavior that you are modifying
## 🚀 New behavior

> Please describe the behavior or changes this PR adds
## 💣 Is this a breaking change (Yes/No):

<!-- If Yes, please describe the impact and migration path for existing Chakra users. -->

## 📝 Additional Information
4 changes: 2 additions & 2 deletions apps/docs/content/components/popover/placements.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const AppTs = `import { Popover, Button, Grid, PopoverPlacement } from "@nextui-org/react";
const AppTs = `import { Popover, Button, Grid, Text, PopoverPlacement } from "@nextui-org/react";
export default function App() {
const placements = [
Expand Down Expand Up @@ -36,7 +36,7 @@ export default function App() {
);
}`;

const AppJs = `import { Popover, Button, Grid } from "@nextui-org/react";
const AppJs = `import { Popover, Button, Text, Grid } from "@nextui-org/react";
export default function App() {
const placements = [
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/grid/grid-container.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const GridContainer = React.forwardRef<
$$gridGapUnit: gapUnit,
display: 'flex',
flexWrap: wrap,
boxZizing: 'border-box',
boxSizing: 'border-box',
margin: 'calc(-1 * $$gridGapUnit)',
width: 'calc(100% + $$gridGapUnit * 2)',
...(css as any)
Expand Down

1 comment on commit 7d60611

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for nextui-docs ready!

✅ Preview
https://nextui-docs-o0d4waed6-nextui-org.vercel.app

Built with commit 7d60611.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.