Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 427/missing component popover docs #428

Merged
merged 4 commits into from
Apr 24, 2022
Merged

Fix 427/missing component popover docs #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ff920a
Container typo
codrin-iftimie Apr 22, 2022
ac84fc0
Merge pull request #425 from codrin-iftimie/main
jrgarciadev Apr 22, 2022
6563040
fix(react-docs): text component was added to placements popover example
jrgarciadev Apr 24, 2022
b6736bf
chore(repo): pull request templated changed
jrgarciadev Apr 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
38 changes: 23 additions & 15 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,28 @@
## [LEVEL]/[COMPONENT]
**TASK**: <!--- [Github ISSUE](Issue Link) -->
<!---
Thanks for creating a Pull Request ❤️!

Please read the following before submitting:
- PRs that adds new external dependencies might take a while to review.
- Keep your PR as small as possible.
- Limit your PR to one type (docs, feature, refactoring, ci, repo, or bugfix)
-->

### Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
Closes # <!-- Github issue # here -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Only
- [ ] Refactor
## 📝 Description

### Description, Motivation and Context
<!--- Describe your changes in detail -->
<!--- Why is this change required? What problem does it solve? -->
<!--- If it is solving an issue... How can it be reproduced in order to compare between both behaviors? -->
> Add a brief description

### Screenshots - Animations
<!-- Adding images or gif animations of your changes improves the understanding of your changes -->
## ⛳️ Current behavior (updates)

> Please describe the current behavior that you are modifying

## 🚀 New behavior

> Please describe the behavior or changes this PR adds

## 💣 Is this a breaking change (Yes/No):

<!-- If Yes, please describe the impact and migration path for existing Chakra users. -->

## 📝 Additional Information
4 changes: 2 additions & 2 deletions apps/docs/content/components/popover/placements.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const AppTs = `import { Popover, Button, Grid, PopoverPlacement } from "@nextui-org/react";
const AppTs = `import { Popover, Button, Grid, Text, PopoverPlacement } from "@nextui-org/react";

export default function App() {
const placements = [
Expand Down Expand Up @@ -36,7 +36,7 @@ export default function App() {
);
}`;

const AppJs = `import { Popover, Button, Grid } from "@nextui-org/react";
const AppJs = `import { Popover, Button, Text, Grid } from "@nextui-org/react";

export default function App() {
const placements = [
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/grid/grid-container.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const GridContainer = React.forwardRef<
$$gridGapUnit: gapUnit,
display: 'flex',
flexWrap: wrap,
boxZizing: 'border-box',
boxSizing: 'border-box',
margin: 'calc(-1 * $$gridGapUnit)',
width: 'calc(100% + $$gridGapUnit * 2)',
...(css as any)
Expand Down