Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exmples): tailwindcss example added #429

Merged
merged 1 commit into from Apr 24, 2022
Merged

feat(exmples): tailwindcss example added #429

merged 1 commit into from Apr 24, 2022

Conversation

jrgarciadev
Copy link
Member

Closes #

馃摑 Description

Tailwindcss example added

鉀筹笍 Current behavior (updates)

Please describe the current behavior that you are modifying

There wasn't a Tailwindcss example

馃殌 New behavior

Please describe the behavior or changes this PR adds

Example added

馃挘 Is this a breaking change (Yes/No):

No

馃摑 Additional Information

Tailwind @base CSS included was removed because it causes conflicts along with NextUI

@jrgarciadev jrgarciadev merged commit 025dc4d into main Apr 24, 2022
@quentin996007
Copy link

What I want to know is, if the base style is removed, then how will we be affected? Is there a more elegant way to resolve this conflict?

@jrgarciadev
Copy link
Member Author

Hey @qinfensky this will affect only the tailwind preflight.css https://github.com/tailwindlabs/tailwindcss/blob/master/src/css/preflight.css , due to NextUI has a CSS baseline with its own CSS reset you shouldn't need the tailwindcss base styles, here the NextUI base styles -> https://github.com/nextui-org/nextui/blob/main/packages/react/src/css-baseline/css-baseline.tsx, as far as I research this is the more elegant way because otherwise you have to use the !important tag to override the tailwindcss base styles

@quentin996007
Copy link

Hey @qinfensky this will affect only the tailwind preflight.css https://github.com/tailwindlabs/tailwindcss/blob/master/src/css/preflight.css , due to NextUI has a CSS baseline with its own CSS reset you shouldn't need the tailwindcss base styles, here the NextUI base styles -> https://github.com/nextui-org/nextui/blob/main/packages/react/src/css-baseline/css-baseline.tsx, as far as I research this is the more elegant way because otherwise you have to use the !important tag to override the tailwindcss base styles

I understand, the explanation is very clear and easy to understand, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants