Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #291 stitches compatability with typescript #434

Merged
merged 1 commit into from Apr 25, 2022
Merged

fix: #291 stitches compatability with typescript #434

merged 1 commit into from Apr 25, 2022

Conversation

tianenpang
Copy link
Member

@tianenpang tianenpang commented Apr 25, 2022

Closes #291

馃摑 Description

Fix the length is declared here issue by upgrading stitches to version 1.2.8

鉀筹笍 Current behavior (updates)

- "@stitches/react": "1.2.7"
+ "@stitches/react": "1.2.8"

馃摑 Additional Information

Screenshot of code completion with latest typescript CSS property

Auto Completion Screenshot

Screenshot of code completion with latest typescript Stitches utils

Auto Completion Screenshot Utils

@codecov-commenter
Copy link

Codecov Report

Merging #434 (faaa0e9) into main (689c2f2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #434   +/-   ##
=======================================
  Coverage   74.77%   74.77%           
=======================================
  Files         174      174           
  Lines        2791     2791           
  Branches      822      822           
=======================================
  Hits         2087     2087           
  Misses        694      694           
  Partials       10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 689c2f2...faaa0e9. Read the comment docs.

@tianenpang tianenpang changed the title fix: stitches compatability with typescript fix: #291 stitches compatability with typescript Apr 25, 2022
@jrgarciadev
Copy link
Member

Thank you so much @tianenpang 馃檹馃徎

@jrgarciadev jrgarciadev added this to the 馃敟 v1.0.0-beta.7 milestone Apr 25, 2022
@jrgarciadev jrgarciadev merged commit 15c0061 into nextui-org:main Apr 25, 2022
@hmbrg
Copy link

hmbrg commented Apr 25, 2022

Thank you, @tianenpang! This makes me very happy!

@jrgarciadev
Copy link
Member

Hope to release it by the weekend 馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants